Frank Kobzik has posted comments on this change. Change subject: core: vdsm -> engine communication for spicevnc ......................................................................
Patch Set 52: (1 comment) http://gerrit.ovirt.org/#/c/28572/52/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 160: return lunsMap; Line 161: } Line 162: Line 163: public static void updateVMDynamicData(VmDynamic vm, Map<String, Object> xmlRpcStruct) { Line 164: updateVMDynamicDataOverridenDisplay(vm, null, xmlRpcStruct); > why do we need another method? Sorry, this was leftover from earlier patches. Its purpose was to handle overriden console address but it's handled in VmStatsVdsBrokerCommand, so I'll remove this. Line 165: } Line 166: Line 167: public static void updateVMDynamicDataOverridenDisplay(VmDynamic vm, VDS vds, Map<String, Object> xmlRpcStruct) { Line 168: if (xmlRpcStruct.containsKey(VdsProperties.vm_guid)) { -- To view, visit http://gerrit.ovirt.org/28572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb38b68ba5a49238d4f9d9cce8475f6af9180077 Gerrit-PatchSet: 52 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
