Omer Frenkel has posted comments on this change. Change subject: core: engine -> vdsm part for spicevnc ......................................................................
Patch Set 51: Code-Review+1 (1 comment) looks ok, minor suggestion inside http://gerrit.ovirt.org/#/c/28571/51/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 103: * this information is used to create graphics devices. Otherwise graphics devices are build from database. Line 104: */ Line 105: @Override Line 106: protected void buildVmGraphicsDevices() { Line 107: boolean isRunOnce = vm.getGraphicsInfos() != null && !vm.getGraphicsInfos().isEmpty(); why not use vm.isRunOnce()? Line 108: boolean usesGraphicsAsDevice = FeatureSupported.graphicsDeviceEnabled(vm.getVdsGroupCompatibilityVersion()); Line 109: Line 110: if (isRunOnce) { Line 111: buildVmGraphicsDevicesRunOnce(vm.getGraphicsInfos(), usesGraphicsAsDevice); -- To view, visit http://gerrit.ovirt.org/28571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6eef54aea60e8fcd7f0d255c6cf72205ae45838 Gerrit-PatchSet: 51 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
