Omer Frenkel has posted comments on this change. Change subject: core: GraphicsInfo db persistence part ......................................................................
Patch Set 34: (1 comment) http://gerrit.ovirt.org/#/c/28570/34/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java: Line 289: * Checking if the function gets the VmStatics in correct order according to MigrationSupport Line 290: */ Line 291: @Test Line 292: public void testGetOrderedVmGuidsForRunMultipleActionsByMigrationSupport() { Line 293: // List<VmStatic> vmStatics = dao.getAllByName(STATIC_VM_NAME); > This needs to be solved (fails even on current master w/o my patches applie i just verified all dao tests pass for me locally on latest master, please re-check Line 294: // VmStatic[] vmStaticArrayInDescOrder = initVmStaticsOrderedByMigrationSupport(vmStatics); Line 295: // Line 296: // execute Line 297: // List<Guid> vmStaticGuidsInDb = -- To view, visit http://gerrit.ovirt.org/28570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a129454fc64aa34493b0495fb76f22f3d667e14 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
