Yair Zaslavsky has posted comments on this change. Change subject: core: WIP move Job, Step to JPA ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34553/4/backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml File backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml: Line 6: <provider>org.hibernate.ejb.HibernatePersistence</provider> Line 7: <non-jta-data-source>java:/ENGINEDataSource</non-jta-data-source> Line 8: <class>org.ovirt.engine.core.common.businessentities.Bookmark</class> Line 9: <class>org.ovirt.engine.core.common.job.Job</class> Line 10: <class>org.ovirt.engine.core.common.job.Step</class> whitespacee... in addition, why have them together at the same patch? because they are related to each other? Line 11: <properties> Line 12: <property name="hibernate.dialect" value="org.hibernate.dialect.PostgreSQLDialect" /> Line 13: <property name="jboss.entity.manager.jndi.name" value="java:/ovirtEM"/> Line 14: <property name="jboss.entity.manager.factory.jndi.name" value="java:/ovirtEMF"/> -- To view, visit http://gerrit.ovirt.org/34553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcfda7b055d37c92c1346b100101c27d594d21fb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
