Yair Zaslavsky has posted comments on this change. Change subject: core : Introduce engine_sessions table and DAO ......................................................................
Patch Set 7: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35148/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java: Line 70: * Comma delimited list of group identifiers. Line 71: */ Line 72: public Collection<Guid> getGroupIds() { Line 73: if (groupIds == null) { Line 74: groupIds = Collections.emptyList(); can be emptySet, but not crucial. Line 75: } Line 76: return new HashSet<Guid>(groupIds); Line 77: } Line 78: -- To view, visit http://gerrit.ovirt.org/35148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4d9cfc3edc6084fc0436ecfd09c82d5ae57f5e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
