Liron Aravot has posted comments on this change. Change subject: core: Prevent operations on the hosted engine disk ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35795/1//COMMIT_MSG Commit Message: Line 9: Prevent the hosted engine disk from being removed, attached to a VM or Line 10: updated Line 11: Line 12: Change-Id: I75c1deee655278a8f575814aea22965be2bfee55 Line 13: Signed-off-by: Tal Nisan <tni...@redhat.com> 1. please fix the order here between bug-url/signed of by 2. what about hotunplug? http://gerrit.ovirt.org/#/c/35795/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java: Line 844: dummy.getSnapshots().addAll(ImagesHandler.getAllImageSnapshots(dummy.getImageId())); Line 845: return dummy; Line 846: } Line 847: Line 848: public static boolean isHostedEngineDisk(Disk disk) { > This is an awkward place for this method - HE's disk is not an Image. I suggest to move it to DiskValidator Line 849: return disk.getDiskStorageType() == DiskStorageType.LUN && Line 850: StorageConstants.HOSTED_ENGINE_LUN_DISK_ALIAS.equals(disk.getDiskAlias()); Line 851: } -- To view, visit http://gerrit.ovirt.org/35795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c1deee655278a8f575814aea22965be2bfee55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
