Alon Bar-Lev has posted comments on this change. Change subject: core: Add ImportCertificateCommand ......................................................................
Patch Set 3: (13 comments) http://gerrit.ovirt.org/#/c/35780/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateCommand.java: Line 70: } Line 71: Line 72: @Override Line 73: protected void setActionMessageParameters() { Line 74: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__IMPORT); here it was: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__PROVIDER_CERTIFICATE_CHAIN); Line 75: } Line 76: Line 77: private void handleException(Throwable e) { Line 78: log.error(String.format("Failed to import certificate: %1$s", e.getMessage())); Line 74: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__IMPORT); Line 75: } Line 76: Line 77: private void handleException(Throwable e) { Line 78: log.error(String.format("Failed to import certificate: %1$s", e.getMessage())); please compare to what you had in the past before you removed this class. log.error("Failed to import certificate: {}", e.getMessage()); Line 79: log.debug("Exception", e); Line 80: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__PROVIDER_CERTIFICATE); Line 81: } Line 76: Line 77: private void handleException(Throwable e) { Line 78: log.error(String.format("Failed to import certificate: %1$s", e.getMessage())); Line 79: log.debug("Exception", e); Line 80: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__PROVIDER_CERTIFICATE); l throw new VdcBLLException(VdcBllErrors.PROVIDER_IMPORT_CERTIFICATE_CHAIN_ERROR, e.getMessage()); Line 81: } http://gerrit.ovirt.org/#/c/35780/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 895 Line 896 Line 897 Line 898 Line 899 so you do need the above or not? if not remove. http://gerrit.ovirt.org/#/c/35780/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java: Line 435 Line 436 Line 437 Line 438 Line 439 do you need ^ or remove? http://gerrit.ovirt.org/#/c/35780/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 22 Line 23 Line 24 Line 25 Line 26 do you need ^ or remove? http://gerrit.ovirt.org/#/c/35780/3/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 279 Line 280 Line 281 Line 282 Line 283 do you need ^ or remove? http://gerrit.ovirt.org/#/c/35780/3/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 499 Line 500 Line 501 Line 502 Line 503 do you need the above or remove? http://gerrit.ovirt.org/#/c/35780/3/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties: Line 392 Line 393 Line 394 Line 395 Line 396 do you need the above or remove? http://gerrit.ovirt.org/#/c/35780/3/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 654 Line 655 Line 656 Line 657 Line 658 ^ same http://gerrit.ovirt.org/#/c/35780/3/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 264 Line 265 Line 266 Line 267 Line 268 Same^ http://gerrit.ovirt.org/#/c/35780/3/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 277 Line 278 Line 279 Line 280 Line 281 Same ^ http://gerrit.ovirt.org/#/c/35780/3/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties: Line 321 Line 322 Line 323 Line 324 Line 325 Same ^ not sure how it related to vdsm -- To view, visit http://gerrit.ovirt.org/35780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4308ecb184234fee3931cf4c7cfbd1796efa9d2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
