Martin Sivák has posted comments on this change.

Change subject: webadmin: Elements in frame in "Scheduling Policy"
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/34276/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-10-20 17:59:01 +0300
Line 4: Commit:     Tomer Saban <tsa...@redhat.com>
Line 5: CommitDate: 2014-10-20 18:12:05 +0300
Line 6: 
Line 7: webadmin: Elements in frame in "Scheduling Policy"
Keep elements in frame?
Line 8: 
Line 9: Did the necessary adjustments in order to keep all the elements in the
Line 10: "New/Clone/Edit Scheduling Policy" inside the frame, by changing
Line 11: it's height.


Line 7: webadmin: Elements in frame in "Scheduling Policy"
Line 8: 
Line 9: Did the necessary adjustments in order to keep all the elements in the
Line 10: "New/Clone/Edit Scheduling Policy" inside the frame, by changing
Line 11: it's height.
its
Line 12: 
Line 13: Change-Id: I7216960d5d7584b387794fb0881944b000d4083f
Line 14: Bug-Url: https://bugzilla.redhat.com/1122420


http://gerrit.ovirt.org/#/c/34276/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml:

Line 85:         width: 100%;
Line 86:         }
Line 87:     </ui:style>
Line 88: 
Line 89:     <d:SimpleDialogPanel width="700px" height="800px">
What is the minimum supported resolution for using ovirt-engine? Making this 
bigger might lead to usability nightmare on 1024x768 or 1366x768 (my X220) 
displays. Please check that with the UX and design guys.
Line 90:         <d:content>
Line 91:             <g:VerticalPanel>
Line 92:                 <g:FlowPanel>
Line 93:                     <g:HorizontalPanel 
addStyleNames="cppv_editors_pfly_fix">


-- 
To view, visit http://gerrit.ovirt.org/34276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7216960d5d7584b387794fb0881944b000d4083f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to