Martin Mucha has posted comments on this change. Change subject: core: misplaced javadoc ......................................................................
Patch Set 1: -Verified (1 comment) http://gerrit.ovirt.org/#/c/32280/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java: Line 34: return interfaces; Line 35: } Line 36: Line 37: /** Line 38: * @param interfaces Interfaces that are connected to a network or bond > This is not accurate. 'interfaces' data member contains all the host's inte I just moved this javadoc to proper location, I did not have knowledge what can be passed there. So what would be better? Remove that improper javadoc entirely or: @param interfaces all host's interfaces: regular interfaces, bonds, slaves, vlan devices Line 39: */ Line 40: public void setInterfaces(List<VdsNetworkInterface> interfaces) { Line 41: this.interfaces = interfaces; Line 42: } -- To view, visit http://gerrit.ovirt.org/32280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf38dc2e1ccaa2c3d0f51c3696c28738f5f48ccf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
