Arik Hadas has posted comments on this change. Change subject: core: change import vm to be VmCommand - part 4 ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/34788/20/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java: Line 56: ImportValidator importValidator = getImportValidator(); Line 57: if (!validate(importValidator.validateUnregisteredEntity(vmFromConfiguration, ovfEntityData, getImages()))) { Line 58: return false; Line 59: } Line 60: setImagesWithStoragePoolId(getParameters().getStoragePoolId(), getVm().getImages()); > Why was this changed, IIRC we don't set the storagePoolId at the paramters thanks! I changed it because of the tests.. I'm currently testing the register and import from configuration flows, they were not verified after the changed I've made because of the tests yet. you saved me some debug time :) Line 61: } Line 62: return super.canDoAction(); Line 63: } Line 64: -- To view, visit http://gerrit.ovirt.org/34788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f182417f9b64f23bb5f412a8e6e20e1c4e2ab6a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
