Juan Hernandez has posted comments on this change. Change subject: restapi: Failed to update VM Cluster in SDK ......................................................................
Patch Set 2: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/35762/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java: Line 137: // to keep backwards compatibility. Line 138: if (incoming.getCpuProfile() != null && vm.getCpuProfile() != null Line 139: && ObjectUtils.equals(incoming.getCpuProfile().getId(), vm.getCpuProfile().getId())) { Line 140: incoming.getCpuProfile().setId(null); Line 141: } Move this logic to the "getParameters" method of the "UpdateParametersProvider" class. Line 142: } Line 143: } Line 144: if (!isFiltered()) { Line 145: //if the user updated the host within placement-policy, but supplied host-name rather than the host-id (legal) - Line 563: if (incoming.isSetInstanceType() && (incoming.getInstanceType().isSetId() || incoming.getInstanceType().isSetName())) { Line 564: updated.setInstanceTypeId(lookupInstanceTypeId(incoming.getInstanceType())); Line 565: } else if (incoming.isSetInstanceType()) { Line 566: // this means that the instance type should be unset Line 567: updated.setInstanceTypeId(null); Here. Line 568: } Line 569: return params; Line 570: } Line 571: } -- To view, visit http://gerrit.ovirt.org/35762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd7dcf86d7257653463e91110909204b6576ca81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
