Liran Zelkha has posted comments on this change. Change subject: core: Removing transaction suspension from command saving/update ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35400/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java: Line 53: Line 54: @Override Line 55: public void put(final CommandEntity cmdEntity) { Line 56: commandMap.put(cmdEntity.getId(), cmdEntity); Line 57: saveOrUpdate(cmdEntity); Surely there was some reason why this was executed outside of a transaction scope... Do you know why? Line 58: } Line 59: Line 60: public void removeAllCommandsBeforeDate(DateTime cutoff) { Line 61: DbFacade.getInstance().getCommandEntityDao().removeAllBeforeDate(cutoff); -- To view, visit http://gerrit.ovirt.org/35400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I885b1d08e6dc1ac00f6ca11bc6fca1df8f044d5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
