Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: moved duplicate UICommand creation to static factory methods ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/33317/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java: Line 35: command.setIsCancel(true); Line 36: return command; Line 37: } Line 38: Line 39: public static UICommand createDefaultCancelUiCommand(String name, NumaSupportModel target) { I think this should be an ICommandTarget, I am guessing this happened because right now the NumaSupportModel is the only model with a default cancel button, but if other models want a default cancel, this will not work. Line 40: UICommand result = createCancelUiCommand(name, target); Line 41: result.setIsDefault(true); Line 42: return result; Line 43: } -- To view, visit http://gerrit.ovirt.org/33317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b3b1344b1a3819e58de4db5093106bedf5291e6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
