Ravi Nori has posted comments on this change. Change subject: core : Modify MLA to use engine session info ......................................................................
Patch Set 9: (4 comments) http://gerrit.ovirt.org/#/c/35362/9/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1293: -- Query Permissions Line 1294: ---------------------------------------------- Line 1295: Line 1296: -- Flatten all the objects a user can get permissions on them Line 1297: CREATE OR REPLACE VIEW user_flat_groups > this one should stay as well? Will check Line 1298: AS Line 1299: SELECT users.user_id AS user_id, fnSplitterUuid(users.group_ids) AS granted_id Line 1300: FROM users Line 1301: UNION ALL Line 1305: -- user is also member of 'Everyone' Line 1306: SELECT user_id, 'EEE00000-0000-0000-0000-123456789EEE' Line 1307: FROM users; Line 1308: Line 1309: CREATE OR REPLACE VIEW engine_session_user_flat_groups > shouldn't this one be used in all the permission views? Will submit a separate patch to fix that Line 1310: AS Line 1311: SELECT id AS id, user_id AS user_id, fnSplitterUuid(engine_sessions.group_ids) AS granted_id Line 1312: FROM engine_sessions Line 1313: UNION ALL http://gerrit.ovirt.org/#/c/35362/9/packaging/dbscripts/user_sp.sql File packaging/dbscripts/user_sp.sql: Line 254: Line 255: Line 256: CREATE OR REPLACE FUNCTION getSessionUserAndGroupsById(v_id UUID, v_engine_session_seq_id INTEGER) Line 257: RETURNS SETOF idUuidType STABLE Line 258: AS $function$ > minor Will fix Line 259: BEGIN Line 260: RETURN QUERY Line 261: select ad_groups.ID from ad_groups,engine_sessions where engine_sessions.id = v_engine_session_seq_id Line 262: and ad_groups.id in(select * from fnsplitteruuid(engine_sessions.group_ids)) Line 264: select v_id Line 265: UNION Line 266: -- user is also member of 'Everyone' Line 267: select 'EEE00000-0000-0000-0000-123456789EEE'; Line 268: END; $function$ > same Will fix -- To view, visit http://gerrit.ovirt.org/35362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f3853166fe635941e65ea2461f7ecda20f4a2a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
