Sandro Bonazzola has posted comments on this change. Change subject: archive: reorganizing the final tarball archive ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35751/1/src/__main__.py File src/__main__.py: Line 1732: conf["local_tmp_dir"], Line 1733: 'working' Line 1734: ) Line 1735: if not os.path.exists(conf["local_working_dir"]): Line 1736: os.makedirs(conf["local_working_dir"]) I would prefer to have the directory created with os.makedirs and handle OSError if directory already exist. Line 1737: else: Line 1738: if len(os.listdir(conf["local_working_dir"])) != 0: Line 1739: raise Exception("""the working directory is not empty. Line 1740: It should be empty so that reports from a prior invocation of the log collector Line 1738: if len(os.listdir(conf["local_working_dir"])) != 0: Line 1739: raise Exception("""the working directory is not empty. Line 1740: It should be empty so that reports from a prior invocation of the log collector Line 1741: are not collected again. Line 1742: The directory is: %s'""" % (conf["local_working_dir"])) You can also use ( "the working directory is not empty. " "It should be empty so that reports from a prior invocation of the log collector " "...." ) instead of """..... """ Line 1743: Line 1744: Line 1745: # We need to make a temporary scratch directory wherein Line 1746: # all of the output from VDSM and PostgreSQL SOS plug-ins -- To view, visit http://gerrit.ovirt.org/35751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If14717e8a9bc790e12c84c1fbaa968d786bed96f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
