Moti Asayag has posted comments on this change. Change subject: core,userportal,webadmin: improper construction of file path ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29655/3/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java: Line 15: assumeNotNull(baseDir); Line 16: Line 17: String fileName = "AppErrors.properties"; Line 18: final File dir = new File(baseDir, "src/main/resources/bundles"); Line 19: File file = new File(dir, fileName); IMO the following is better self-explained: Path path = Paths.get(baseDir, "/src/main/resources/bundles/", "AppErrors.properties"); DuplicateKeysCheck.assertNoDuplicateKeys(path.toString()); or even join path and file name: Path path = Paths.get(baseDir, "/src/main/resources/bundles/AppErrors.properties"); Line 20: DuplicateKeysCheck.assertNoDuplicateKeys(file.getAbsolutePath()); Line 21: } Line 22: -- To view, visit http://gerrit.ovirt.org/29655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd073d100931003ab33cb6ea28df4260c7d5548a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
