Amit Aviram has posted comments on this change. Change subject: core: Preventing moving a shareable disk to a Gluster domain ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35398/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java: Line 77: } Line 78: Line 79: private boolean verifyShareableDisksMoving() { Line 80: Map<Guid, StorageDomain> targetDomains= new HashMap<>(); Line 81: List<String> problematicDisks = new LinkedList<>(); > 1. this call can return null (the disks weren't check yet for existence). ok, I'll move it to the place it belongs- thanks Line 82: for ( MoveDiskParameters param : getParameters().getParametersList() ) { Line 83: // fail if there are shareable disks that are being moved to a gluster domain. Line 84: DiskImage currDisk = getDiskImageDao().get(param.getImageId()); Line 85: if (currDisk.isShareable()) { -- To view, visit http://gerrit.ovirt.org/35398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37e500e86d2b6094bb257221a4ca899590aed610 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
