Martin Mucha has posted comments on this change. Change subject: core: lenient validation of mac pool ranges in engine-config ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35390/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java: Line 80: return new ValidationResult(false, Line 81: String.format("The entered range is invalid. " Line 82: + "Range should be specified as " Line 83: + "<lowerBoundMAC>"+ MacAddressRangeUtils.BOUNDARIES_DELIMITER +"<upperBoundMAC>." Line 84: + " Did you mean %s?", > maybe i miss here something - but isn't there a mismatch between the number no, you're right of course. I dropped info about current value (it'd be there twice) and overlooked this. Line 85: MacAddressRangeUtils.boundariesToRangeString(from, to), Line 86: MacAddressRangeUtils.boundariesToRangeString(to, from))); Line 87: Line 88: } -- To view, visit http://gerrit.ovirt.org/35390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7e47c1ab1c2ffd340e1ff2596ee567557324a28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
