Tomas Jelinek has posted comments on this change. Change subject: removed unneeded classes ......................................................................
Patch Set 4: (1 comment) If I understand properly, the http://gerrit.ovirt.org/#/c/35193/ is just some preparation but you anyway delete most of it in this patch. I'd say it would make much more sense to squash this two patches together with one common commit message... http://gerrit.ovirt.org/#/c/35286/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java: Line 1462: protected ConsoleContext getConsoleContext() { Line 1463: return ConsoleContext.UP_EXTENDED; Line 1464: } Line 1465: Line 1466: private class UsePortalListModelUpdateAndReorderVmNicsAsyncCallback extends UpdateAndReorderVmNicsAsyncCallback { typo: UserPortal... Line 1467: Line 1468: public UsePortalListModelUpdateAndReorderVmNicsAsyncCallback(UnitVmModel model, Guid vmId) { Line 1469: super(model, vmId); Line 1470: } -- To view, visit http://gerrit.ovirt.org/35286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2a13a3f29e1101f559f6661af382bc9691351f7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
