Martin Mucha has posted comments on this change. Change subject: core: Improved message when MAC Pool cannot be deleted ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/30663/11/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 36: Line 37: @DefaultStringValue("Not enough MAC addresses left in MAC Address Pool.") Line 38: String MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES(); Line 39: Line 40: @DefaultStringValue("Cannot ${action} ${type}. Several ${entities} (${ENTITIES_USING_NETWORK_COUNTER}) are using this ${type}:\n${DATACENTERS_USING_MAC_POOL}\n - Please remove it from all ${entities} that are using it and try again.") > the content of the message isn't like the other, should be: Done Line 41: String ACTION_TYPE_FAILED_CANNOT_REMOVE_STILL_USED_MAC_POOL(); Line 42: Line 43: @DefaultStringValue("$entities Data Centers") Line 44: String VAR__ENTITIES__DATA_CENTERS(); -- To view, visit http://gerrit.ovirt.org/30663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I647420d7cc43853eddd2b17091cd627b9088a34d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
