Omer Frenkel has posted comments on this change. Change subject: core: VM Monitoring abstract fetching/analyzing/monitoring ......................................................................
Patch Set 20: (2 comments) http://gerrit.ovirt.org/#/c/28662/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 309: private void logFailureMessage(RuntimeException ex) { Line 310: log.warn( Line 311: "Failed to refresh VDS , vds = '{}' : '{}', error = '{}', continuing.", Line 312: cachedVds.getName(), Line 313: cachedVds.getId()); this is still wrong, please look how it was in master: the message expects for 3 params: name,id, ex.msg you are passing only 2... Line 314: log.error("Exception", ex.getMessage()); Line 315: } Line 316: Line 317: private static void logException(final RuntimeException ex) { Line 310: log.warn( Line 311: "Failed to refresh VDS , vds = '{}' : '{}', error = '{}', continuing.", Line 312: cachedVds.getName(), Line 313: cachedVds.getId()); Line 314: log.error("Exception", ex.getMessage()); now this is wrong, should be just ex Line 315: } Line 316: Line 317: private static void logException(final RuntimeException ex) { Line 318: log.error("ResourceManager::refreshVdsRunTimeInfo", ex); -- To view, visit http://gerrit.ovirt.org/28662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1adf0a95007140e89b080b5160ba93e340ee3ba6 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
