Vered Volansky has posted comments on this change. Change subject: core: disable illegal operations on a pooled VM ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/35457/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 280: } Line 281: return true; Line 282: } Line 283: Line 284: protected boolean validateVmNotAttachedToPool() { > The name is confusing - a VM may very well be attached to a pool, and you c I'll take you up on your suggestion as I have nothing better in mind :) Line 285: if ((updateReadOnlyRequested() || updateWipeAfterDeleteRequested()) && getVm().getVmPoolId() != null) Line 286: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_ATTACHED_TO_POOL); Line 287: return true; Line 288: } Line 282: } Line 283: Line 284: protected boolean validateVmNotAttachedToPool() { Line 285: if ((updateReadOnlyRequested() || updateWipeAfterDeleteRequested()) && getVm().getVmPoolId() != null) Line 286: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_ATTACHED_TO_POOL); > Same problem with the constant's name ack Line 287: return true; Line 288: } Line 289: Line 290: protected boolean validateCanResizeDisk() { -- To view, visit http://gerrit.ovirt.org/35457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3a6e1542f3ef4fb78f074b62e854a4907dfbca6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
