Allon Mureinik has posted comments on this change. Change subject: core: use config value when possible ......................................................................
Patch Set 2: >> Allon ,these values are not currently in ConfigValues. Did you mean you want >> them added there? In this patch? Yes. I don't see the point in leaving some constants in the validator and some as conf. values, especially when the distinction seems random. -- To view, visit http://gerrit.ovirt.org/33918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic87e7406be257d7706084c3264fc85b08795d83c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
