Allon Mureinik has posted comments on this change. Change subject: core: Restore storage_pool_id to storage_domain_for_search ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35627/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 372: (SELECT storage_id, Line 373: count(storage_id) > 1 AS is_multi_domain, Line 374: max(storage_pool_iso_map.status) AS status, Line 375: array_to_string(array_agg(storage_pool.name), ',') AS pool_names, Line 376: CASE WHEN COUNT(distinct storage_pool.id) = 1 THEN array_agg(storage_pool.id) ELSE NULL END as storage_pool_ids > COUNT is an expensive operation , any chance ti implement that without an a At worst, this will count four or five DCs - i don't think it would be noticible. Any better suggestion? I really don't want to clatter up the database with another function we define. Line 377: FROM storage_pool_iso_map Line 378: JOIN storage_pool ON storage_pool_iso_map.storage_pool_id = storage_pool.id Line 379: GROUP BY storage_id) AS status_table ON storage_domain_static.id=status_table.storage_id Line 380: LEFT OUTER JOIN (SELECT DISTINCT storage_domain_id -- To view, visit http://gerrit.ovirt.org/35627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
