Yair Zaslavsky has posted comments on this change. Change subject: core: Inject instead of expensive JNDI lookups ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Comment on your comment :) http://gerrit.ovirt.org/#/c/35495/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 107: Line 108: public abstract class CommandBase<T extends VdcActionParametersBase> extends AuditLogableBase implements Line 109: RollbackHandler, TransactionMethod<Object>, Command<T> { Line 110: Line 111: // lazy instance injection as an instance isn't needed most of the time I wonder if the comment is correct. Storage related commands are quite common, don't you think? I wouldn't even bother to add this comment, as obviously Injection is a good approach. Line 112: @Inject Line 113: private Instance<BackendCommandObjectsHandler> commandObjectsHandlerProvider; Line 114: Line 115: /* Multiplier used to convert GB to bytes or vice versa. */ -- To view, visit http://gerrit.ovirt.org/35495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1efa3a0cefa2f2ece6cd0c5aa4f8be8dd07055f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
