Arik Hadas has uploaded a new change for review.
Change subject: core: minor cleanup in StopVmCommandBase#destroyVm
......................................................................
core: minor cleanup in StopVmCommandBase#destroyVm
* Change running on VDS command statements to be more concise
* Remove redundant initialization of Guid field
Change-Id: Ia07c80eba0120ca9fdea4f1c9328bffdb3c30a96
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
1 file changed, 8 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/35671/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
index 8992dff..105e51e 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
@@ -81,19 +81,16 @@
protected void destroyVm() {
if (getVm().getStatus() == VMStatus.MigratingFrom &&
getVm().getMigratingToVds() != null) {
- Backend.getInstance()
- .getResourceManager()
- .RunVdsCommand(
- VDSCommandType.DestroyVm,
- new DestroyVmVDSCommandParameters(new
Guid(getVm().getMigratingToVds().toString()),
- getVmId(),
getParameters().getStopReason(), true, false, 0));
+ Backend.getInstance().getResourceManager().RunVdsCommand(
+ VDSCommandType.DestroyVm,
+ new
DestroyVmVDSCommandParameters(getVm().getMigratingToVds(),
+ getVmId(), getParameters().getStopReason(), true,
false, 0));
}
- setActionReturnValue(Backend
- .getInstance()
- .getResourceManager()
- .RunVdsCommand(VDSCommandType.DestroyVm,
- new DestroyVmVDSCommandParameters(getVdsId(), getVmId(),
getParameters().getStopReason(), false, false, 0)).getReturnValue());
+
setActionReturnValue(Backend.getInstance().getResourceManager().RunVdsCommand(
+ VDSCommandType.DestroyVm,
+ new DestroyVmVDSCommandParameters(getVdsId(), getVmId(),
+ getParameters().getStopReason(), false, false,
0)).getReturnValue());
}
@Override
--
To view, visit http://gerrit.ovirt.org/35671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia07c80eba0120ca9fdea4f1c9328bffdb3c30a96
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
