Tal Nisan has uploaded a new change for review. Change subject: core: Reduced visibility of methods in ExportVmCommand ......................................................................
core: Reduced visibility of methods in ExportVmCommand Change-Id: I07ccaed16483a25a4798954bc6bb96e8ef344877 Signed-off-by: Tal Nisan <tni...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/35668/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java index 3223e91..f1fc690 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java @@ -180,7 +180,7 @@ return true; } - protected boolean handleDestStorageDomain(List<DiskImage> disksList) { + private boolean handleDestStorageDomain(List<DiskImage> disksList) { ensureDomainMap(disksList, getStorageDomainId()); List<DiskImage> dummiesDisksList = createDiskDummiesForSpaceValidations(disksList); dummiesDisksList.addAll(getMemoryVolumes()); @@ -255,7 +255,7 @@ return !getDisksBasedOnImage().isEmpty(); } - public boolean updateCopyVmInSpm(Guid storagePoolId, VM vm, Guid storageDomainId) { + private boolean updateCopyVmInSpm(Guid storagePoolId, VM vm, Guid storageDomainId) { HashMap<Guid, KeyValuePairCompat<String, List<Guid>>> vmsAndMetaDictionary = new HashMap<Guid, KeyValuePairCompat<String, List<Guid>>>(); OvfManager ovfManager = new OvfManager(); @@ -295,8 +295,7 @@ getVm().setVmtGuid(VmTemplateHandler.BLANK_VM_TEMPLATE_ID); String vmMeta = ovfManager.ExportVm(vm, AllVmImages, ClusterUtils.getCompatibilityVersion(vm)); - vmsAndMetaDictionary - .put(vm.getId(), new KeyValuePairCompat<String, List<Guid>>(vmMeta, imageGroupIds)); + vmsAndMetaDictionary.put(vm.getId(), new KeyValuePairCompat<String, List<Guid>>(vmMeta, imageGroupIds)); UpdateVMVDSCommandParameters tempVar = new UpdateVMVDSCommandParameters(storagePoolId, vmsAndMetaDictionary); tempVar.setStorageDomainId(storageDomainId); return runVdsCommand(VDSCommandType.UpdateVM, tempVar) @@ -318,7 +317,7 @@ return disksImages; } - protected void copyAllMemoryImages(Guid containerID) { + private void copyAllMemoryImages(Guid containerID) { for (Snapshot snapshot : snapshotsWithMemory) { List<Guid> guids = GuidUtils.getGuidListFromString(snapshot.getMemoryVolume()); @@ -510,7 +509,7 @@ return super.getAuditLogTypeValue(); } - protected boolean updateVmInSpm() { + private boolean updateVmInSpm() { Map<Guid, KeyValuePairCompat<String, List<Guid>>> metaDictionary = new HashMap<Guid, KeyValuePairCompat<String, List<Guid>>>(); OvfDataUpdater.getInstance().loadVmData(getVm()); -- To view, visit http://gerrit.ovirt.org/35668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I07ccaed16483a25a4798954bc6bb96e8ef344877 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches