Sahina Bose has posted comments on this change. Change subject: core: Inject TransactionSupport instead of JNDI lookups ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/35637/3//COMMIT_MSG Commit Message: Line 7: core: Inject TransactionSupport instead of JNDI lookups Line 8: Line 9: TransactionSupport is now injected into command base. Line 10: Line 11: No for jndi lookups which envolvs syncs on context lookup. No need for? Line 12: Line 13: Also create DummyTransactionSupport for unit tests so no need for Line 14: EjbStrategy Class Rule Line 15: http://gerrit.ovirt.org/#/c/35637/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java: Line 91: mockConfig(ConfigValues.GlusterHostUUIDSupport, "3.1", false), Line 92: mockConfig(ConfigValues.GlusterHostUUIDSupport, "3.2", false), Line 93: mockConfig(ConfigValues.GlusterHostUUIDSupport, "3.3", true)); Line 94: Line 95: @ClassRule Not required anymore? Line 96: public static MockEJBStrategyRule ejbRule = new MockEJBStrategyRule(); Line 97: Line 98: private GlusterSyncJob glusterManager; Line 99: private GlusterAuditLogUtil logUtil; -- To view, visit http://gerrit.ovirt.org/35637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2a73887c76c85b17db6a3c2683d257aece10b59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
