Omer Frenkel has posted comments on this change. Change subject: core: monitoring - Host Monitoring handles Vms Monitoring exeption ......................................................................
Patch Set 17: (3 comments) http://gerrit.ovirt.org/#/c/27922/17/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 134: if (vds.getStatus() != VDSStatus.PreparingForMaintenance && vds.getStatus() != VDSStatus.Maintenance) { Line 135: ResourceManager.getInstance().runVdsCommand(VDSCommandType.SetVdsStatus, Line 136: new SetVdsStatusVDSCommandParameters(vds.getId(), VDSStatus.Error)); Line 137: } Line 138: } catch (VDSNetworkException e) { i dont understand why you added this here, if we have network err in refreshVdsStats(); (same for refreshCaps) it is calling it inside, and re-throwing, so it will be called again? if now, refreshVmStats also call this, we are covered, no? Line 139: saveVdsDynamic = vdsManager.handleNetworkException(e, vds); Line 140: throw e; Line 141: } catch (Throwable t) { Line 142: log.error("Failure to refresh Vds runtime info: {}", t.getMessage()); http://gerrit.ovirt.org/#/c/27922/17/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 199: RuntimeException callException = vdsReturnValue.getExceptionObject(); Line 200: if (callException != null) { Line 201: if (callException instanceof VDSErrorException) { Line 202: log.error("Failed vds listing, vds='{}'({}): {}", vds.getId(), Line 203: vds.getName(), vdsReturnValue.getExceptionString()); on master, they changed the looging order, first name, then id, please change back.. Line 204: } else if (callException instanceof VDSProtocolException) { Line 205: log.error("Failed vds listing, vds='{}'({}): {}", Line 206: vds.getName(), vds.getId(), vdsReturnValue.getExceptionString()); Line 207: } Line 250: || (vmToUpdate.getStatus() != runningVm.getStatus() && Line 251: !(vmToUpdate.getStatus() == VMStatus.PreparingForHibernate && runningVm.getStatus() == VMStatus.Up)) ) { Line 252: VDSReturnValue vmStats = Line 253: getResourceManager().runVdsCommand( Line 254: VDSCommandType.GetVmStats, no need for network error handling here? Line 255: new GetVmStatsVDSCommandParameters(vds, runningVm.getId())); Line 256: if (vmStats.getSucceeded()) { Line 257: runningVms.put(runningVm.getId(), (VmInternalData) vmStats.getReturnValue()); Line 258: statusChanged = true; -- To view, visit http://gerrit.ovirt.org/27922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb98b6f05fa6f3bb02c59f5217e46c93c3b6875 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
