Sahina Bose has posted comments on this change. Change subject: engine: Allow simultaneous add of gluster host ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35635/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java: Line 399: if (vds.getStatus() != VDSStatus.Installing && Line 400: vds.getStatus() != VDSStatus.InstallingOS && Line 401: vds.getStatus() != VDSStatus.PendingApproval && Line 402: vds.getStatus() != VDSStatus.Initializing) Line 403: return true; > this returns true if at least one vds in cluster not in "initialization" st No, what I wanted is this - if there are other hosts in cluster and there is no operational host, I don't want to allow addition of gluster host. However if the other hosts in cluster are in the process of installing or initializing, then I want to allow the add. The reason, when the host comes UP - in InitVdsOnUpCommand, we try to peer probe the host to add to trusted storage pool - using "gluster peer probe" command. We want to avoid the case where hosts in one cluster end up in multiple gluster pools, depending on which host was UP when the "gluster peer probe" was done. Line 404: } Line 405: return false; Line 406: } Line 407: -- To view, visit http://gerrit.ovirt.org/35635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f1f81c90d2ec727159a2ed4d147a0acffd60ab9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
