Maor Lipchuk has posted comments on this change.
Change subject: core: AsyncTaskDAO: make log final
......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
Consider remove this log entirely from here, not sure how a log is good for dao
layer, but can be in another patch.
ack for me
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
Line 27: * {@code DbFacade}.
Line 28: */
Line 29: public class AsyncTaskDAODbFacadeImpl extends BaseDAODbFacade
implements AsyncTaskDAO {
Line 30: private static final Guid[] EMPTY_GUIDS_ARRAY = new Guid[0];
Line 31: private static final Log log =
LogFactory.getLog(AsyncTaskDAODbFacadeImpl.class);
Consider remove this log entirely from here, not sure how a log is good for dao
layer, but can be in another patch.
Line 32:
Line 33: private static class IdRowMapper implements
ParameterizedRowMapper<Guid> {
Line 34:
Line 35: @Override
--
To view, visit http://gerrit.ovirt.org/7111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8de2c586d10f6655aaeac86861d8763b750a02d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
