Ravi Nori has uploaded a new change for review. Change subject: webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog ......................................................................
webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog Misalignment in New Host Dialog in jp_JP and fr_FR locales Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e Bug-Url: https://bugzilla.redhat.com/1123324 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/35603/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java index 8616a01..17ad9fd 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java @@ -511,7 +511,7 @@ private void addStyles() { overrideIpTablesEditor.addContentWidgetStyleName(style.overrideIpStyle()); protocolEditor.addContentWidgetStyleName(style.protocolStyle()); - externalHostProviderEnabledEditor.addContentWidgetStyleName(style.checkBox()); + externalHostProviderEnabledEditor.addContentWidgetStyleName(style.externalHostProviderEnabledEditorContent()); providerSearchFilterEditor.addContentWidgetStyleName(style.searchFilter()); providerSearchFilterEditor.setStyleName(style.searchFilterLabel()); providerSearchFilterEditor.setLabelStyleName(style.emptyEditor()); @@ -520,6 +520,7 @@ fetchSshFingerprint.addContentWidgetStyleName(style.fingerprintEditor()); expanderContent.setStyleName(style.expanderContent()); publicKeyEditor.setCustomStyle(style.pkStyle()); + tabPanel.addBarStyle(style.bar()); } private void initEditors() { @@ -1116,6 +1117,10 @@ String pkStyle(); String fetchResultErrorLabel(); + + String bar(); + + String externalHostProviderEnabledEditorContent(); } public void setPkPasswordSectionVisiblity(boolean visible) { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml index 6b74f87..0c34cfb 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml @@ -234,13 +234,27 @@ } .policyOverrideLabel { - max-width: 80%; + max-width: 55%; line-height: 1.2em; display: inline-block; } + + .bar { + width: 175px; + } + + .externalHostProviderEnabledEditor { + width: 270px; + } + + .externalHostProviderEnabledEditorContent { + width: 270px; + padding: 0px !important; + border-width: 0px !important; + } </ui:style> - <d:SimpleDialogPanel width="700px" height="715px"> + <d:SimpleDialogPanel width="740px" height="715px"> <d:content> <t:DialogTabPanel ui:field="tabPanel" height="100%"> <t:tab> @@ -251,7 +265,7 @@ <e:ListModelListBoxEditor ui:field="dataCenterEditor"/> <e:ListModelListBoxEditor ui:field="clusterEditor"/> <g:HorizontalPanel width="100%"> - <ge:EntityModelCheckBoxEditor ui:field="externalHostProviderEnabledEditor"/> + <ge:EntityModelCheckBoxEditor ui:field="externalHostProviderEnabledEditor" addStyleNames="{style.externalHostProviderEnabledEditor}"/> <e:ListModelListBoxEditor ui:field="providersEditor"/> </g:HorizontalPanel> <g:FlowPanel> -- To view, visit http://gerrit.ovirt.org/35603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
