Liron Aravot has uploaded a new change for review.
Change subject: core: ReconstructMasterDomain - executing host shouldn't
disconnect from pool
......................................................................
core: ReconstructMasterDomain - executing host shouldn't disconnect from pool
when executing ReconstructMasterDomain command, the executing host
shouldn't be disconnected from pool and can be only connected.
Change-Id: I25182021dd264c168a94cd77ad1dcb5490f68660
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
1 file changed, 0 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/7136/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
index ea0228a..7b9188c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
@@ -13,15 +13,12 @@
import org.ovirt.engine.core.common.businessentities.VDSStatus;
import org.ovirt.engine.core.common.businessentities.VM;
import org.ovirt.engine.core.common.businessentities.storage_pool_iso_map;
-import org.ovirt.engine.core.common.config.Config;
-import org.ovirt.engine.core.common.config.ConfigValues;
import org.ovirt.engine.core.common.errors.VdcBLLException;
import org.ovirt.engine.core.common.errors.VdcBllErrors;
import org.ovirt.engine.core.common.interfaces.SearchType;
import org.ovirt.engine.core.common.queries.SearchParameters;
import org.ovirt.engine.core.common.queries.VdcQueryType;
import
org.ovirt.engine.core.common.vdscommands.ConnectStoragePoolVDSCommandParameters;
-import
org.ovirt.engine.core.common.vdscommands.DisconnectStoragePoolVDSCommandParameters;
import
org.ovirt.engine.core.common.vdscommands.MarkPoolInReconstructModeVDSCommandParameters;
import org.ovirt.engine.core.common.vdscommands.ReconstructMarkAction;
import
org.ovirt.engine.core.common.vdscommands.ReconstructMasterVDSCommandParameters;
@@ -102,17 +99,6 @@
new MarkPoolInReconstructModeVDSCommandParameters(
getStoragePoolId().getValue(),
ReconstructMarkAction.ClearJobs));
boolean commandSucceeded = stopSpm();
-
- final List<String> disconnectPoolFormats = Config.<List<String>>
GetValue(
- ConfigValues.DisconnectPoolOnReconstruct);
-
- if (commandSucceeded &&
disconnectPoolFormats.contains(getNewMaster(true).getStorageFormat().getValue()))
{
- commandSucceeded = runVdsCommand(
- VDSCommandType.DisconnectStoragePool,
- new
DisconnectStoragePoolVDSCommandParameters(getVds().getId(),
- getStoragePool().getId(), getVds().getvds_spm_id())
- ).getSucceeded();
- }
if (!commandSucceeded) {
return false;
--
To view, visit http://gerrit.ovirt.org/7136
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25182021dd264c168a94cd77ad1dcb5490f68660
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
