Martin Pavlásek has posted comments on this change. Change subject: guest monitor: split monitor from thread ......................................................................
Patch Set 5: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31591/5/mom/GuestMonitor.py File mom/GuestMonitor.py: Line 56: threading.Thread.__init__(self, name="guest:%s" % id) Line 57: Line 58: self.setName("GuestMonitor-%s" % info['name']) Line 59: self.setDaemon(True) Line 60: self.logger = logging.getLogger('mom.GuestMonitor') I think here should be used name 'mom.GuestMonitorThread'. 'mom.GuestMonitor' logger is already used in GuestMonitor class above Line 61: Line 62: self._mon = monitor Line 63: Line 64: def run(self): -- To view, visit http://gerrit.ovirt.org/31591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I224104f8b353d92a420723d3415df94aaf68da0c Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Pavlásek <mpavl...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
