Martin Sivák has posted comments on this change. Change subject: core: check if the HE guest can be migrated before maintenace ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35401/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java: Line 108: private boolean canScheduleVm(VM vm) { Line 109: return SchedulingManager.getInstance().canSchedule( Line 110: getVdsGroup(), Line 111: vm, Line 112: new ArrayList<Guid>(), //no blacklist We usually blacklist the current host iirc. Migrating to self is something we do not check for yet. Please verify that it will block the maintenance if there really is only a single host. Line 113: new ArrayList<Guid>(), //no whitelist Line 114: vm.getDedicatedVmForVds(), Line 115: new ArrayList<String>() Line 116: ); -- To view, visit http://gerrit.ovirt.org/35401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9cbcd03f01ca34c6c31308b7321214e15cafc7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
