Ravi Nori has posted comments on this change. Change subject: core : Persist engine session on login and delete on logout ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/35361/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java: Line 17: import org.ovirt.engine.core.dal.dbbroker.DbFacade; Line 18: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; Line 19: import org.ovirt.engine.core.utils.timer.OnTimerMethodAnnotation; Line 20: Line 21: public class SessionDataContainer { > Can you please consider having DbFacade injected? Can you elaborate how you want me to do it? Line 22: Line 23: private static class SessionInfo { Line 24: private ConcurrentMap<String, Object> contentOfSession = new ConcurrentHashMap<>(); Line 25: Line 251: private String getPrincipalName(String sessionId) { Line 252: return (String) getData(sessionId, PRINCIPAL_PARAMETER_NAME, false); Line 253: } Line 254: Line 255: DbFacade dbFacade; > why package visibility and not private? Done Line 256: Line 257: public void setDbFacade(DbFacade dbFacade) { Line 258: this.dbFacade = dbFacade; Line 259: } http://gerrit.ovirt.org/#/c/35361/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java: Line 17: private String engineSessionId; Line 18: Line 19: private Collection<Guid> roleIds; Line 20: Line 21: private DbUser dbUser; > why store as member? I thought you are interested in getting values out of Done Line 22: Line 23: public EngineSession() { Line 24: dbUser = new DbUser(); Line 25: } -- To view, visit http://gerrit.ovirt.org/35361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
