Omer Frenkel has posted comments on this change.

Change subject: core: added event log when mixing RHLE 6 and 7 in one cluster
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/35497/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java:

Line 136: 
Line 137:                 vdsNonOperational(vds, 
NonOperationalReason.MIXING_RHEL_VERSIONS_IN_CLUSTER, customLogValues);
Line 138:                 vds.setStatus(VDSStatus.NonOperational);
Line 139: 
Line 140:                 logAuditLogEvent(vds, customLogValues, 
AuditLogType.MIXING_RHEL_VERSIONS_IN_CLUSTER);
you don't need to log it manually, its the SetNonOperationalVdsCommand job
just add the right case in getAuditLogTypeValue() method
Line 141:             }
Line 142:         }
Line 143:     }
Line 144: 


-- 
To view, visit http://gerrit.ovirt.org/35497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8e58e10f181b6742b88b464739ed39610ac69de
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to