Allon Mureinik has posted comments on this change. Change subject: core: Entities.deviceByDeviceId ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35447/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java: Line 104: return Collections.emptyMap(); Line 105: } Line 106: } Line 107: Line 108: public static Map<Guid, VmDevice> devicesByDeviceId(List<VmDevice> entityList) { > Allon, this is not exactly what i meant to in my comment to Maor's patch - no - VmDevice.getId() returns a pair of ids - for the device and the vm. This is an ID for the device only. Line 109: if (entityList != null && !entityList.isEmpty()) { Line 110: Map<Guid, VmDevice> map = new HashMap<Guid, VmDevice>(); Line 111: for (VmDevice device : entityList) { Line 112: map.put(device.getDeviceId(), device); -- To view, visit http://gerrit.ovirt.org/35447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If10b5036f310c1f0967d305adf77fbe07220a049 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
