Allon Mureinik has posted comments on this change. Change subject: core: OVFs that aren't stored on any domain should be stored on all ......................................................................
Patch Set 6: Code-Review+2 (2 comments) Please fix the inline comments before merging http://gerrit.ovirt.org/#/c/34292/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java: Line 176: if (tasks.isEmpty()) { Line 177: log.info("no tasks for the deactivated domain {0}, proceeding with deactivation", getStorageDomainId()); Line 178: return; Line 179: } else { Line 180: log.info("tasks {0} were found for domain {1}, waiting before attempting to deactivate", tasks, getStorageDomainId()); The logging infra has changed - please use {} instead of numbered params. Line 181: } Line 182: } Line 183: } http://gerrit.ovirt.org/#/c/34292/6/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 599: BEGIN Line 600: RETURN QUERY SELECT vs.vm_guid Line 601: FROM vm_static vs Line 602: WHERE vs.vm_guid NOT IN (SELECT DISTINCT vd.vm_id Line 603: FROM vm_device vd INNER JOIN base_disks i please have the inner join on its own line Line 604: ON i.disk_id = vd.device_id Line 605: AND vd.snapshot_id IS NULL Line 606: WHERE i.shareable = v_shareable); Line 607: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/34292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeecc6c4526800656315842384d83830fdf0b72b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
