Juan Hernandez has posted comments on this change. Change subject: cleanup: remove void statement from cert.conf ......................................................................
Patch Set 5: Looks good to me, but someone else must approve This change looks harmless, but shouldn't we fix CreateReq.sh so that it generates cert.conf properly? Or if that is not needed cleanup the script (and its callers) so that it doesn't receive the country, organization and name parameters? -- To view, visit http://gerrit.ovirt.org/6882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a558649e5509b5807aa142a9def5fa5b0477f2b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches