Yair Zaslavsky has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35485/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateQuery.java: Line 28: ProviderProxy proxy = ProviderProxyFactory.getInstance().create(provider); Line 29: List<? extends Certificate> chain = proxy.getCertificateChain(); Line 30: if (!chain.isEmpty()) { Line 31: try { Line 32: getQueryReturnValue().setReturnValue(new Base64().encodeToString(chain.get(chain.size() - 1) > a. you can put anything you want in setReturnValue why? what will this class have, why not a collection of string? Line 33: .getEncoded())); Line 34: } catch (CertificateEncodingException e) { Line 35: getQueryReturnValue().setSucceeded(false); Line 36: log.error("Error in encoding certificate. Error is {} " + e.getMessage()); -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
