Liron Aravot has posted comments on this change. Change subject: core: Push ioTune QoS info when hotplugging disk ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35353/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java: Line 69: drive.put(VdsProperties.PropagateErrors, disk.getPropagateErrors().toString().toLowerCase()); Line 70: Line 71: VmInfoBuilder.handleIoTune(getParameters().getVm(), vmDevice, diskImage, Line 72: new HashMap<Guid, Guid>(), new HashMap<Guid, Map<String, Long>>()); Line 73: drive.put(VdsProperties.SpecParams, vmDevice.getSpecParams()); consider to put it only if it != null or verify that if the value is null there's no affect in vdsm side. other then that looks good to me. Line 74: } else { Line 75: LunDisk lunDisk = (LunDisk) disk; Line 76: Line 77: // If SCSI pass-through is enabled (VirtIO-SCSI/DirectLUN disk and SGIO is defined), -- To view, visit http://gerrit.ovirt.org/35353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
