Roy Golan has posted comments on this change. Change subject: core: do not instantiate singleton class ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/30513/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java: Line 96: if (!constructor.isAccessible()) { Line 97: isAcessible = constructor.isAccessible(); Line 98: constructor.setAccessible(true); Line 99: } Line 100: CommandBase<?> cmd = (CommandBase<?>) constructor.newInstance(commandId); nice. no redundant arrays Line 101: Injector.injectMembers(cmd); Line 102: return cmd; Line 103: } catch (Exception e) { Line 104: log.error( -- To view, visit http://gerrit.ovirt.org/30513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id142e03724cf83e10aa631e2785632610d7cecc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
