Yair Zaslavsky has posted comments on this change. Change subject: engine: Adding Manipulate provider action group ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35494/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java: Line 71: Line 72: @Override Line 73: public List<PermissionSubject> getPermissionCheckSubjects() { Line 74: return Collections.singletonList(new PermissionSubject(Guid.SYSTEM, Line 75: VdcObjectType.System, > wouldn't we like to manage the permission per specific user ? This means that the system should have provider as an object in our MLA hierarchy, right? I guess we should take this into a wider discussion, and for now defer the patch. Line 76: ActionGroup.MANIPULATE_PROVIDERS)); Line 77: } Line 78: Line 79: @Override -- To view, visit http://gerrit.ovirt.org/35494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I360db0b3168331ca0c67335679bfc825461e5091 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
