Mike Kolesnik has posted comments on this change.
Change subject: core: AsyncTaskManager: Useless @SuppressWarnings
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 288: try {
Line 289: poolsAsyncTaskMap.put(storagePoolID, new
HashMap<Guid, AsyncTaskStatus>(
Line 290: (Map<Guid, AsyncTaskStatus>)
Backend.getInstance().getResourceManager().RunVdsCommand(
Line 291: VDSCommandType.SPMGetAllTasksStatuses,
Line 292: new
IrsBaseVDSCommandParameters(storagePoolID)).getReturnValue()));
The return value from a VDSCommand is indeed an object, so this cast will cause
a warning which this annotation prevents
Line 293: } catch (RuntimeException e) {
Line 294: if ((e instanceof VdcBLLException) &&
Line 295: (((VdcBLLException) e).getErrorCode() ==
VdcBllErrors.VDS_NETWORK_ERROR)) {
Line 296: log.debugFormat("Get SPM task statuses: Calling
Command {1}{2}, " +
--
To view, visit http://gerrit.ovirt.org/7109
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d6edcd4223e9b7242d8421826b385356178171
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
