Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: add element ids to all general subtabs ......................................................................
Patch Set 4: > re: the generateIds() calls -- I need to call them again after UIBinder is > setup. Else the UIBinder fields don't get their IDs because they are all null. You're right, IDs should be generated and assigned only after UI is initialized via UiBinder. I'm wondering what's the purpose of calling generateIds() in AbstractSubTabFormView constructor - at that time, UI cannot be initialized. Can we remove generateIds() from AbstractSubTabFormView constructor then? This call was added as part of http://gerrit.ovirt.org/#/c/32146/ - Alex what do you think? -- To view, visit http://gerrit.ovirt.org/34800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b281e7b130dd0bbcb23887719e79ab615a901d6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
