Alon Bar-Lev has posted comments on this change. Change subject: core: Store only single certificate ......................................................................
Patch Set 18: (2 comments) http://gerrit.ovirt.org/#/c/33717/18/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java: Line 18: private static final Logger log = LoggerFactory.getLogger(ExternalTrustStoreInitializer.class); Line 19: Line 20: public static void init() { Line 21: if (!EngineLocalConfig.getInstance().getExternalProvidersTrustStore().exists()) { Line 22: try (OutputStream out = no need to create empty file. Line 23: new FileOutputStream(EngineLocalConfig.getInstance().getExternalProvidersTrustStore())) { Line 24: String password = EngineLocalConfig.getInstance().getPKITrustStorePassword(); Line 25: KeyStore trustStore = KeyStore.getInstance(KeyStore.getDefaultType()); Line 26: // Passing null stream will create a new empty trust store Line 54: Line 55: } Line 56: Line 57: public static void saveTrustStore(KeyStore keystore) { Line 58: try (OutputStream out = new FileOutputStream(EngineLocalConfig.getInstance().getExternalProvidersTrustStore())) { this should use temp file Line 59: keystore.store(out, EngineLocalConfig.getInstance().getExternalProvidersTrustStorePassword().toCharArray()); Line 60: } Line 61: catch (Exception e) { Line 62: throw new RuntimeException(e); -- To view, visit http://gerrit.ovirt.org/33717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9bd8cd7f913cf23eca839452b6e113f749966f7 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
