Martin Mucha has posted comments on this change. Change subject: restapi: rest part of UpdateAndReorderVmNicsCommand ......................................................................
Patch Set 6: "…while this patch exposes the vnic order command." ~ not sure about which command are you talking. "According to the bug, you should have been support for adding multiple nics on vm creation" ~ yes, but we solve more problems here, than just ones depicted in bug. There was code on presentation layer doing stuff which should be done on backend and which is missing on rest ~ and just for that asked the bug. But to be able to do that, I have to create that backend command and *I should* (so I did) get rid of obsolete code from presentation layer. If you were talking about VdcActionType.UpdateAndReorderVmNics, then this command, just as its "gui father code", does additions, updates, deletion and reordering of VmNics. -- To view, visit http://gerrit.ovirt.org/35054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I633276253651d486b4d890413548bc3317357781 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
