Ondřej Macháček has posted comments on this change. Change subject: aaa: Retrive values from domain using case insensitve name of the domain ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35439/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java: Line 165 Line 166 Line 167 Line 168 Line 169 > I do not like the conversion of lower case, except for maybe detect key nam All the values are called from attachConfigValuesFromDb. And then split by ':' in getValue method. So if it will be lowercased there then all other values which are called from attachConfigValuesFromDb will be lower cased too. Not sure what is best solution. -- To view, visit http://gerrit.ovirt.org/35439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieeaf9c922d6d3f0b9bd2a4480859c4ce483454f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
