Daniel Erez has posted comments on this change. Change subject: restapi: Support multiple links to DC from SD ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35406/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java: Line 475: // Find all the data centers that this storage domain is attached to and add references to them: Line 476: Guid storageDomainId = Guid.createGuidFromString(model.getId()); Line 477: List<Guid> dataCenterIds = StorageDomainHelper.getAttachedDataCenters(this, storageDomainId); Line 478: if (!CollectionUtils.isEmpty(dataCenterIds)) { Line 479: DataCenters dataCenters = new DataCenters(); can it be extracted to the helper? this logic seems to repeat itself.. Line 480: for (Guid dataCenterId : dataCenterIds) { Line 481: DataCenter dataCenter = new DataCenter(); Line 482: dataCenter.setId(dataCenterId.toString()); Line 483: dataCenters.getDataCenters().add(dataCenter); -- To view, visit http://gerrit.ovirt.org/35406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55c52309645f73d7a790c07135c21acf91feb824 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
